Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otlploghttp: Use go.opentelemetry.io/proto/slim/otlp #5216

Merged
merged 2 commits into from
Apr 17, 2024
Merged

otlploghttp: Use go.opentelemetry.io/proto/slim/otlp #5216

merged 2 commits into from
Apr 17, 2024

Conversation

pellared
Copy link
Member

Part of #2579

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 16, 2024
@pellared pellared marked this pull request as ready for review April 16, 2024 12:59
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.3%. Comparing base (dbe27d4) to head (1c6b0bc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           main   #5216      +/-   ##
=======================================
+ Coverage      0   84.3%   +84.3%     
=======================================
  Files         0     258     +258     
  Lines         0   17042   +17042     
=======================================
+ Hits          0   14381   +14381     
- Misses        0    2362    +2362     
- Partials      0     299     +299
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/client.go 100.0% <ø> (ø)
...otlp/otlplog/otlploghttp/internal/transform/log.go 95.2% <ø> (ø)

... and 256 files with indirect coverage changes

@pellared pellared merged commit fe3de70 into open-telemetry:main Apr 17, 2024
27 checks passed
@pellared pellared deleted the otlploghttp-use-slim branch April 17, 2024 10:20
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 19, 2024
@pellared pellared mentioned this pull request Apr 22, 2024
Closed
XSAM added a commit to XSAM/opentelemetry-go that referenced this pull request Apr 22, 2024
@XSAM
Revert "otlploghttp: Use go.opentelemetry.io/proto/slim/otlp (open-te…
4771fe3 
…lemetry#5216)"

This reverts commit fe3de70.
@XSAM XSAM mentioned this pull request Apr 22, 2024
Merged
pellared pushed a commit that referenced this pull request Apr 23, 2024
@XSAM
Revert the usage of go.opentelemetry.io/proto/slim (#5253)
bf37c5a 
* Revert "otlpmetrichttp: Use go.opentelemetry.io/proto/slim/otlp (#5222)"

This reverts commit 6e92163.

* Revert "otlploghttp: Use go.opentelemetry.io/proto/slim/otlp (#5216)"

This reverts commit fe3de70.

* Remove slim dep

* Fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pellared @dashpole @MrAlias