Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool otlploghttp transform maps #5378

Merged
merged 8 commits into from
May 22, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 17, 2024

Part of #5196

Benchmarks

goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp/internal/transform
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
               │   old.txt   │               new.txt               │
               │   sec/op    │   sec/op     vs base                │
ResourceLogs-8   6.033µ ± 4%   5.249µ ± 8%  -13.00% (p=0.000 n=10)

               │    old.txt    │               new.txt                │
               │     B/op      │     B/op      vs base                │
ResourceLogs-8   10.602Ki ± 0%   8.299Ki ± 0%  -21.72% (p=0.000 n=10)

               │  old.txt   │              new.txt              │
               │ allocs/op  │ allocs/op   vs base               │
ResourceLogs-8   188.0 ± 0%   178.0 ± 0%  -5.32% (p=0.000 n=10)

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:exporter:otlp Related to the OTLP exporter package labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (0a7aae7) to head (eeb750f).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5378   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        268     268           
  Lines      17796   17808   +12     
=====================================
+ Hits       15052   15064   +12     
  Misses      2430    2430           
  Partials     314     314           
Files Coverage Δ
...otlp/otlplog/otlploghttp/internal/transform/log.go 98.5% <100.0%> (+<0.1%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review May 17, 2024 21:18
@pellared pellared merged commit e800298 into open-telemetry:main May 22, 2024
26 checks passed
@MrAlias MrAlias deleted the pool-otlploghttp-maps branch May 22, 2024 14:35
@MrAlias MrAlias added this to the v1.28.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs pkg:exporter:otlp Related to the OTLP exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants