Restore the experimental/streaming SDK implementation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
bogdandrutu,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
Closed
rghetia
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
(1) this restores the basic functionality of the
experimental/streamingdirectory. While there are still no tests, this SDK is not meant to go into production, so I feel it's worth making incremental changes for demonstration.(2) this eliminates a few helpers for lazy Events that were still in the (experimental) SDK; this should be discussed separately, for now these helpers were removed from the examples.
(3) this demonstrates how to eliminate span state, including protection against double-finish calls, as discussed here: #23 (comment)