Fix clobbering of the span context if extraction fails #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
jmacd,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
jmacd
approved these changes
Apr 23, 2020
MrAlias
approved these changes
Apr 23, 2020
seh
reviewed
Apr 23, 2020
This causes problems if multiple trace propagators are chained, because the first propagator in chain may extract a valid span context, then next propagator will overwrite it with an empty span context when required headers in supplier are missing.
seh
approved these changes
Apr 27, 2020
|
Updated and rebased. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655.