Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default metrics to othttp instrumentation Fixes #542 #861

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Add default metrics to othttp instrumentation Fixes #542 #861

merged 5 commits into from
Jun 26, 2020

Conversation

AndrewGrachov
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 23, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@lizthegrey
Copy link
Member

@AndrewGrachov please ensure your commit email address is the same as your github email address

@lizthegrey lizthegrey added the blocked:CLA Waiting on CLA to be signed before progress can be made label Jun 23, 2020
@AndrewGrachov AndrewGrachov changed the title Add default metrics to othttp instrumentation Add default metrics to othttp instrumentation Fixes #542 Jun 23, 2020
@AndrewGrachov
Copy link
Contributor Author

I signed it

@lizthegrey lizthegrey removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Jun 23, 2020
jmacd
jmacd approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just some nits. Fine to merge as-is.

instrumentation/othttp/handler.go Outdated Show resolved Hide resolved
instrumentation/othttp/handler.go Outdated Show resolved Hide resolved
@jmacd
Copy link
Contributor

jmacd commented Jun 23, 2020

I should add that there is an effort to standardize the metrics we get from span-oriented calls, here: open-telemetry/opentelemetry-specification#654

When this standard is finished, we'll probably want to change this instrumentation. Have you given your input on that issue?

Aneurysm9
Aneurysm9 reviewed Jun 23, 2020
View reviewed changes
instrumentation/othttp/handler.go Outdated Show resolved Hide resolved
instrumentation/othttp/common.go Outdated Show resolved Hide resolved
instrumentation/othttp/common.go Outdated Show resolved Hide resolved
instrumentation/othttp/handler.go Outdated Show resolved Hide resolved
instrumentation/othttp/handler.go Outdated Show resolved Hide resolved
@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Jun 23, 2020
@AndrewGrachov
Copy link
Contributor Author

I signed it

evantorrie
evantorrie approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd mentioned this pull request Jun 25, 2020
Closed
MrAlias
MrAlias approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor punctuation and capitalization changes requested, but nothing is a blocker.

api/standard/http.go Outdated Show resolved Hide resolved
instrumentation/othttp/config.go Outdated Show resolved Hide resolved
@jmacd @MrAlias
Apply suggestions from code review
c9a81cc 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@jmacd jmacd merged commit e8226c4 into open-telemetry:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@evantorrie evantorrie evantorrie approved these changes

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndrewGrachov @lizthegrey @jmacd @Aneurysm9 @MrAlias @evantorrie