Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api/standard constant names and documentation #920

Merged
merged 6 commits into from Jul 9, 2020
Merged

Fix api/standard constant names and documentation #920

merged 6 commits into from Jul 9, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 8, 2020

  • Update the package documentation to point to the specification version the semantic conventions implement (or soon will with the next milestone).
  • Append Key to FaaS* constants to match existing style.

@MrAlias MrAlias added the pkg:API Related to an API package label Jul 8, 2020
@MrAlias MrAlias added this to the Implement v0.6.0 Specification milestone Jul 8, 2020
@MrAlias MrAlias self-assigned this Jul 8, 2020
@MrAlias MrAlias merged commit fab431e into open-telemetry:master Jul 9, 2020
@MrAlias MrAlias deleted the fix-sem-conv-names branch July 9, 2020 18:56
@MrAlias MrAlias mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@evantorrie evantorrie evantorrie approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees

@MrAlias MrAlias

Labels
pkg:API Related to an API package
Projects
None yet
Milestone
Implement v0.6.0 Specification
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrAlias @Aneurysm9 @evantorrie