Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help wanted! Convert Groovy tests to Java #7195

Open
trask opened this issue Nov 16, 2022 · 9 comments
Open

Help wanted! Convert Groovy tests to Java #7195

trask opened this issue Nov 16, 2022 · 9 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome

Comments

@trask
Copy link
Member

trask commented Nov 16, 2022 •
edited by laurit

We've made some initial progress in #7148, #6613, #6537, #6497, #6484, #6486, #6485, #5774, #5688, #5679, #5668, #5660, #5596, #5581, #5521, #5504, #5399, #3768, #3525 (among others)

But there's so much more! 😅

Pick your favorite(s) and help us convert one or two (or ten!)
@trask trask added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Nov 16, 2022
@trask trask pinned this issue Nov 22, 2022
@trask trask changed the title Convert Groovy tests to Java Convert Groovy tests to Java [help wanted!] Nov 22, 2022
@trask trask changed the title Convert Groovy tests to Java [help wanted!] Help wanted! Convert Groovy tests to Java Nov 22, 2022
@laurit laurit mentioned this issue Dec 18, 2022
Merged
@anuragagarwal561994 anuragagarwal561994 mentioned this issue Dec 26, 2022
Open
trask pushed a commit that referenced this issue Jan 3, 2023
@laurit
Convert vaadin tests to java (#7444)
d0bfc5b 
Part of
#7195
Resolves
#7417
Vaadin tests often break with a new version of vaadin. To improve this
tests were change to assert only the traces and spans that are common in
all the versions.
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Jan 23, 2023
Merged
trask pushed a commit that referenced this issue Jan 23, 2023
Migrate reactor-netty-0.9 tests to java (#7635)
7657b75 
Part of #7195
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Jan 27, 2023
Merged
mateuszrzeszutek pushed a commit that referenced this issue Jan 30, 2023
Rewrite netty 3.8 tests to Java (#7666)
245a9f7 
Part of #7195
@xiangtianyu xiangtianyu mentioned this issue Jan 30, 2023
Merged
mateuszrzeszutek pushed a commit that referenced this issue Feb 1, 2023
@xiangtianyu
convert http url connection test from groovy to java (#7676)
6885c80 
related to #7195
@xiangtianyu xiangtianyu mentioned this issue Feb 4, 2023
Merged
mateuszrzeszutek pushed a commit that referenced this issue Feb 7, 2023
@xiangtianyu
convert jedis test from groovy to java (#7731)
c9a0462 
related to #7195
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Feb 13, 2023
Merged
@anuragagarwal561994 anuragagarwal561994 mentioned this issue Feb 26, 2023
Merged
@trask trask mentioned this issue Feb 27, 2023
Merged
trask pushed a commit that referenced this issue Feb 27, 2023
@anuragagarwal561994
HttpClient 4.0 java tests (#7912)
7bb978d 
Converts apache-httpclient-4.0 unit tests in java. Version 4.0 was using
GuardedBy annotation which was interfering with the test cases, hence
the library version was shifted to 4.1.
#7195
This was referenced Mar 4, 2023
Merged
Merged
@kaibocai7 kaibocai7 mentioned this issue Mar 5, 2023
Merged
laurit pushed a commit that referenced this issue Mar 11, 2023
@heyams
Convert Jetty 11 groovy to java (#7976)
995baa8 
related to
#7195
laurit pushed a commit that referenced this issue Mar 11, 2023
@heyams
Convert Jetty 8.0 groovy to java (#7975)
468aa9e 
related to
#7195
@abhisesh abhisesh mentioned this issue Mar 23, 2023
Merged
@niteshs7 niteshs7 mentioned this issue Mar 26, 2023
Merged
mateuszrzeszutek pushed a commit that referenced this issue Mar 27, 2023
@abhisesh
Convert spring-data tests from groovy to java (#8124)
aa2c243 
Related to #7195.

Converts spring data instrumentation tests from groovy to java.
mateuszrzeszutek pushed a commit that referenced this issue Mar 28, 2023
@niteshs7
Convert Geode test from Groovy to Java (#8141)
cfc0ff7 
Related to #7195 

Converts Geode test from Groovy to Java.
@abhisesh abhisesh mentioned this issue Mar 30, 2023
Merged
@niteshs7 niteshs7 mentioned this issue Mar 30, 2023
Merged
This was referenced Oct 5, 2023
Merged
Merged
@123liuziming 123liuziming mentioned this issue Oct 13, 2023
Merged
This was referenced Oct 15, 2023
Merged
Merged
@jaydeluca jaydeluca mentioned this issue Nov 2, 2023
Merged
@vallabhnatu vallabhnatu mentioned this issue Nov 5, 2023
Merged
@happyuser23 happyuser23 mentioned this issue Nov 14, 2023
Merged
@jaydeluca jaydeluca mentioned this issue Nov 15, 2023
Merged
@jaydeluca
Copy link
Contributor

The issue has been open for about a year now, here's the latest progress report:

latest

@heyams heyams mentioned this issue Nov 30, 2023
Merged
@jaydeluca jaydeluca mentioned this issue Dec 2, 2023
Merged
@jaydeluca jaydeluca mentioned this issue Dec 11, 2023
Merged
@happyuser23 happyuser23 mentioned this issue Dec 18, 2023
Merged
@zeitlinger
Copy link
Member

zeitlinger commented Dec 21, 2023 •
edited

Just tried both IDEA and copilot for converting, but neither was able to do it.
Nor chatGPT. This is the test case: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-batch-3.0/javaagent/src/test/groovy/SpringBatchTest.groovy

@hadesy hadesy mentioned this issue Jan 5, 2024
Merged
@jeanbisutti jeanbisutti mentioned this issue Jan 8, 2024
Closed
@steverao steverao mentioned this issue Feb 12, 2024
Merged
@jaydeluca jaydeluca mentioned this issue Feb 23, 2024
Merged
@jaydeluca
Copy link
Contributor

in my travels I've come across a few that can be checked off in the checklist:

@jaydeluca jaydeluca mentioned this issue Feb 24, 2024
Merged
@jaydeluca jaydeluca mentioned this issue Mar 17, 2024
Merged
@zackman0010 zackman0010 mentioned this issue Apr 17, 2024
Merged
@jaydeluca jaydeluca mentioned this issue Apr 18, 2024
Merged
@jaydeluca jaydeluca mentioned this issue Apr 26, 2024
Merged
@jaydeluca
Copy link
Contributor

Latest progress update:

progress

This was referenced May 19, 2024
Merged
Merged
This was referenced May 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trask @AlexanderWert @zeitlinger @jaydeluca