Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Generating client span for SCG while using opentelemetry-spring-boot-starter #10742

Closed
wants to merge 0 commits into from

Conversation

123liuziming
Copy link
Contributor

related to issue #10648

@123liuziming 123liuziming requested a review from a team as a code owner March 4, 2024 11:53
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Mar 4, 2024
@zeitlinger
Copy link
Member

please add a unit test

@123liuziming
Copy link
Contributor Author

please add a unit test

Yes, I am working on that!

@123liuziming
Copy link
Contributor Author

123liuziming commented Mar 12, 2024

I've tried to use micrometer-tracing in Reactor Netty to add client span for Spring Cloud Gateway's HttpClient. The Webflux's server span ends before the Reactor Netty's HTTP span
4c900d3c146c29e6600053ff7d1f372

The Webflux span is the parent span of Reactor Netty's hostname resolution span.
c95b602a5087ea7d7158cec9c46c66f

The HTTP span is not in the trace...
14f78ee5787f86e7b8ed69b8601135c

@123liuziming
Copy link
Contributor Author

Maybe we need to enhance each reactor.netty.http.client.HttpClient bean in Spring Context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants