Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactor netty micrometer #11148

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Reactor netty micrometer #11148

wants to merge 8 commits into from

Conversation

123liuziming
Copy link
Contributor

No description provided.

@123liuziming 123liuziming requested a review from a team as a code owner April 17, 2024 03:58
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Apr 17, 2024
@123liuziming 123liuziming mentioned this pull request Apr 17, 2024
Open
@laurit
Copy link
Contributor

laurit commented Apr 17, 2024

Do we really want to make our spring boot starter depend on micrometer?

@zeitlinger
Copy link
Member

Do we really want to make our spring boot starter depend on micrometer?

No, I don't think we want to do that - so it should be library instead of implementation.

Apart from that, we're discussing how much we want to support micrometer in the SIG meeting tomorrow: https://docs.google.com/document/d/1WK9h4p55p8ZjPkxO75-ApI9m0wfea6ENZmMoFRvXSCw/edit#bookmark=id.q3aculj8d8qn

@breedx-splk
Copy link
Contributor

Hey @123liuziming it sounds like this is probably not the route we want to go for this. Would you be ok with closing this and/or discussing it further? Thanks.

@trask trask added the needs author feedback Waiting for additional feedback from the author label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment.

@github-actions github-actions bot added the stale label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs author feedback Waiting for additional feedback from the author stale test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@123liuziming @laurit @zeitlinger @breedx-splk @trask