Cache default enabled config #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
May 10, 2021
iNikem
reviewed
May 10, 2021
Comment on lines
236
to
243
| static boolean initDefaultEnabled(Config config) { | ||
| return config.getBooleanProperty("otel.instrumentation.common.default-enabled", true); | ||
| } | ||
|
|
||
| // visible for testing | ||
| static boolean initEnabled( | ||
| Config config, List<String> instrumentationNames, boolean defaultEnabled) { | ||
| return config.isInstrumentationEnabled(instrumentationNames, defaultEnabled); |
There was a problem hiding this comment.
I don't understand why these methods a called init? They don't initialise anything. I am confused by them
|
|
||
| cleanup: | ||
| Config.INSTANCE = null | ||
| InstrumentationModule.initDefaultEnabled(config) == enabled |
There was a problem hiding this comment.
Is this method called only from test? They I don't see any point in neither the method nor the test.
|
|
||
| cleanup: | ||
| Config.INSTANCE = null | ||
| InstrumentationModule.initEnabled(config, [name, altName], false) == enabled |
There was a problem hiding this comment.
This also does not look like a test for InstrumentationModule, more like for Config.
|
@iNikem I inlined those methods and removed the corresponding tests. Previously I was trying (too hard?) to keep the tests intact, which was the purpose of extracting those methods. PTAL |
iNikem
approved these changes
May 10, 2021
...rc/main/java/io/opentelemetry/javaagent/extension/instrumentation/InstrumentationModule.java
Outdated
Show resolved
Hide resolved
…nt/extension/instrumentation/InstrumentationModule.java Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was made possible by #1643