Don't pass configuration to SDK autoconfigure through system props #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
|
|
||
| /** | ||
| * Returns a boolean-valued configuration property or {@code defaultValue} if a property with name | ||
| * {@code name} has not been configured. | ||
| */ | ||
| public boolean getBooleanProperty(String name, boolean defaultValue) { |
There was a problem hiding this comment.
I'm planning to rename all get*Property() methods to get*() in the next PR - those shorter names seem a bit nicer, and they're consistent with the SDK ConfigProperties interface too.
There was a problem hiding this comment.
is the plan to have this implement ConfigProperties then?
There was a problem hiding this comment.
Unfortunately that won't be possible with the current shape of this repo: instrumentation-api only uses OTel API, not the SDK, so we can't directly implement the ConfigProperties interface here.
added 2 commits
August 18, 2021 10:55
trask
approved these changes
Aug 19, 2021
Comment on lines
-85
to
-92
| allProperties.forEach( | ||
| (key, value) -> { | ||
| if (!environmentProperties.containsKey(key) | ||
| && key.startsWith("otel.") | ||
| && !key.startsWith("otel.instrumentation")) { | ||
| System.setProperty(key, value); | ||
| } | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.