Rename Config get*Property() methods to get*() #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
| } | ||
|
|
||
| /** | ||
| * Returns a list-valued configuration property or {@code defaultValue} if a property with name | ||
| * {@code name} has not been configured. The format of the original value must be comma-separated, | ||
| * e.g. {@code one,two,three}. | ||
| */ | ||
| public List<String> getListProperty(String name, List<String> defaultValue) { | ||
| public List<String> getList(String name, List<String> defaultValue) { |
There was a problem hiding this comment.
I used simpler getList/getMap names instead of getCommaSeparatedValues/getCommaSeparatedMap that SDK uses -- all other method names are consistent with the ConfigProperties interface.
There was a problem hiding this comment.
Seems like a nice change we can make to the SDK too (since it's alpha)
anuraaga
approved these changes
Aug 20, 2021
instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/config/ConfigTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * Returns a list-valued configuration property or {@code defaultValue} if a property with name | ||
| * {@code name} has not been configured. The format of the original value must be comma-separated, | ||
| * e.g. {@code one,two,three}. | ||
| */ | ||
| public List<String> getListProperty(String name, List<String> defaultValue) { | ||
| public List<String> getList(String name, List<String> defaultValue) { |
There was a problem hiding this comment.
Seems like a nice change we can make to the SDK too (since it's alpha)
mateuszrzeszutek
force-pushed
the
rename-config-methods
branch
from
b7d91a2
to
d97a923
Compare
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
I had to leave all those old methods and make them deprecated -- muzzle wouldn't let me remove them in this PR, I'll have to do that in the next one.
trask
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and rewrite the rest of the Spock test to JUnit.
See #3866 (comment)