Fix memleak in the Netty ChannelPipeline instrumentation #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
approved these changes
Sep 7, 2021
trask
approved these changes
Sep 7, 2021
tydhot
reviewed
Sep 7, 2021
| @@ -109,4 +112,20 @@ public static void removeHandler( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @SuppressWarnings("unused") | |||
| public static class RemoveFirstLastAdvice { | |||
There was a problem hiding this comment.
I have some questions about the handling of removelast, if user call removelast here, maybe the handler be removed will be ourHander? And the origin handler will be remained if user only call removelast once.
There was a problem hiding this comment.
Yeah, you're exactly right - I'll create a separate issue for this, since it has never worked correctly.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully that should resolve #4040