Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jax-rs async cancel handling #4279

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Jax-rs async cancel handling #4279

merged 1 commit into from
Oct 4, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 4, 2021

Make AsyncResponse.cancel handling use OnMethodEnter advice instead of OnMethodExit because span is already finished by the time of OnMethodExit and it might be already sent out without the jaxrs.canceled attribute.
Should reproduce when JerseyHttpServerTest is run with strict context stressor.

@trask trask merged commit f7c4dea into open-telemetry:main Oct 4, 2021
@laurit laurit deleted the jaxrs-async-cancel branch July 6, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurit @trask @mateuszrzeszutek