Revert "Always set parent of agent class loader to bootstrap class loader (#5169)" #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Feb 19, 2022
anuraaga
approved these changes
Feb 19, 2022
|
closing in favor of #5408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5401 by reverting #5169. I will re-open #5156. I would open an issue to create a smoke test for the prometheus exporter, but we already have one #4516 😞.
Unfortunately, this PR is creating a regression to fix a regression 😞. But the regression it's fixing is a high-priority long existing use case, while the regression its causing is a more recently discovered issue related to JPMS support.