aws-sdk-2.2: More reflection cleanup. #8775
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
...c/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2SqsTracingTest.groovy
Outdated
Show resolved
Hide resolved
...ws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/SqsAccess.java
Show resolved
Hide resolved
This is required to avoid enabled=false in some cases.
| } | ||
| public void doTransform(TypeTransformer transformer) { | ||
| transformer.applyAdviceToMethod( | ||
| isConstructor(), SqsInstrumentationModule.class.getName() + "$RegisterAdvice"); |
There was a problem hiding this comment.
isConstructor would apply to the constructor of software.amazon.awssdk.core.SdkClient which is an interface (https://github.com/aws/aws-sdk-java-v2/blob/c7c731f81d68403ce50b60dea61f413c269e57d0/core/sdk-core/src/main/java/software/amazon/awssdk/core/SdkClient.java#L27).
It does work though, and we would not depend on the Advice actually being invoked as long as the helper classes are injected.
There was a problem hiding this comment.
I think you could also use none(), as you noted the isConstructor() match is impossible here, but as it is only needed to trigger class injection it does not need to match anyway. The none() to trigger injection trick is also used in OpenTelemetryInstrumentation
There was a problem hiding this comment.
Changed that in a7683fd and some related cleanup.
|
Build failures seem to be entirely unrelated, testLatestDeps (only) seems to consistently (or at least twice) fail in |
mongo latest dep test failure should be fixed with #8785 Latest dep tests test agains the latest version of the library, occasional breakage is expected when new library versions are released |
.../aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/SqsImpl.java
Outdated
Show resolved
Hide resolved
…pentelemetry/instrumentation/awssdk/v2_2/SqsImpl.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Follow-up to #8603, addressing some comments & finishing the half-done cleanup.