aws-sdk-2.2.: Support injection into SQS.SendMessageBatch message attributes #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
force-pushed
the
feature/sqs-batch
branch
from
456f50a
to
8b48a0b
Compare
|
Rebased & updated PR description. |
Oberon00
force-pushed
the
feature/sqs-batch
branch
from
b695eee
to
0b4c6b8
Compare
mateuszrzeszutek
approved these changes
Jun 26, 2023
...c/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2SqsTracingTest.groovy
Outdated
Show resolved
Hide resolved
...c/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2SqsTracingTest.groovy
Show resolved
Hide resolved
| trace(1, xrayInjectionEnabled ? 4 : 3) { | ||
| span(0) { | ||
| name "Sqs.SendMessageBatch" | ||
| kind CLIENT // TODO: Probably this should be producer, but that would be a breaking change |
There was a problem hiding this comment.
👍
In general I think it'd make sense for SQS to implement the messaging semconv; but that's probably a quite large project, and we might just defer it until the messaging semconv stability.
…/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2SqsTracingTest.groovy Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
|
@Oberon00 can you resolve the conflicts? thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing after #8775, this PR contains both more refactorings and the SQS SendMessageBatch injection support. If requested, I can move the refactorings (all commits before 456f50a, which at the time of PR creation is the last commit) to a separate PR.