Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty 4.1: handle closing connection before the request completes #9157

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Aug 8, 2023

Resolves #9116
If client closes the connection before response is written we may end up not ending the span. To fix this this pr adds ending all the open spans when channel is closed.

@laurit laurit requested a review from a team August 8, 2023 16:15
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is merged first, I can rebase into #9160

@laurit laurit merged commit bf000fe into open-telemetry:main Aug 9, 2023
44 checks passed
@laurit laurit deleted the netty41-cancelation branch August 9, 2023 15:05
breedx-splk pushed a commit to breedx-splk/opentelemetry-java-instrumentation that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span not end if request canceled in webflux application
3 participants