Add exporter data classes for experimental profiling signal type.

Changes addressing code review comments.
open-telemetry · May 17, 2024 · 55b8ab6 · 55b8ab6
1 parent bda144f
commit 55b8ab6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/...rofiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/AggregationTemporality.java b/...rofiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/AggregationTemporality.java
@@ -26,9 +26,6 @@
  */
 public enum AggregationTemporality {
 
-  /** The default AggregationTemporality, it MUST not be used. */
-  UNSPECIFIED,
-
   /**
    * DELTA is an AggregationTemporality for a profiler which reports changes since last report time.
    */

diff --git a/exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/LinkData.java b/exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/LinkData.java
@@ -5,9 +5,6 @@
 
 package io.opentelemetry.exporter.otlp.profiles;
 
-import io.opentelemetry.api.internal.OtelEncodingUtils;
-import io.opentelemetry.api.trace.SpanId;
-import io.opentelemetry.api.trace.TraceId;
 import javax.annotation.concurrent.Immutable;
 
 /**

diff --git a/...rs/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/ValueTypeData.java b/...rs/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/ValueTypeData.java
@@ -5,6 +5,7 @@
 
 package io.opentelemetry.exporter.otlp.profiles;
 
+import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 
 /**
@@ -21,5 +22,6 @@ public interface ValueTypeData {
   /** Index into string table. */
   long unit();
 
+  @Nullable
   AggregationTemporality aggregationTemporality();
 }