Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3.2.1 #6128

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.zipkin.reporter2:zipkin-reporter-bom 3.1.1 -> 3.2.1 age adoption passing confidence

Release Notes

openzipkin/zipkin-reporter-java (io.zipkin.reporter2:zipkin-reporter-bom)

v3.2.1: Zipkin Reporter 3.2

Compare Source

Zipkin Reporter 3.2 deprecates Sender for a simpler type BytesMessageSender. This only supports synchronous invocation (as used by the async reporters in the reporting thread) and requires senders to pass an empty list vs a complicated and usually implemented check() function. The result is being able to implement a custom sender in less than 50 lines including imports like below! Thank a lot to @​anuraaga and @​reta for the review on this.

package brave.example;

import com.linecorp.armeria.client.WebClient;
import com.linecorp.armeria.common.AggregatedHttpResponse;
import com.linecorp.armeria.common.HttpData;
import com.linecorp.armeria.common.HttpMethod;
import com.linecorp.armeria.common.HttpRequest;
import com.linecorp.armeria.common.MediaType;
import java.io.IOException;
import java.util.List;
import zipkin2.reporter.BytesMessageEncoder;
import zipkin2.reporter.BytesMessageSender;
import zipkin2.reporter.ClosedSenderException;
import zipkin2.reporter.Encoding;

final class WebClientSender extends BytesMessageSender.Base {
  final WebClient zipkinApiV2SpansClient;
  volatile boolean closeCalled; // volatile as not called from the reporting thread.

  WebClientSender(WebClient zipkinApiV2SpansClient) {
    super(Encoding.JSON);
    this.zipkinApiV2SpansClient = zipkinApiV2SpansClient;
  }

  @​Override public int messageMaxBytes() {
    return 500_000; // Use the most common HTTP default
  }

  @&#8203;Override public void send(List<byte[]> encodedSpans) throws IOException {
    if (closeCalled) throw new ClosedSenderException();
    byte[] body = BytesMessageEncoder.JSON.encode(encodedSpans);
    HttpRequest request =
        HttpRequest.of(HttpMethod.POST, "", MediaType.JSON, HttpData.wrap(body));
    AggregatedHttpResponse response = zipkinApiV2SpansClient.blocking().execute(request);
    try (HttpData content = response.content()) {
      if (!response.status().isSuccess()) {
        if (content.isEmpty()) {
          throw new IOException("response failed: " + response);
        }
        throw new IOException("response failed: " + content.toStringAscii());
      }
    }
  }

  @&#8203;Override public void close() {
    closeCalled = true;
  }

Full Changelog: https://github.com/openzipkin/zipkin-reporter-java/compare/3.1.1..3.2.1

v3.2.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 8, 2024 00:37
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (491de70) 91.03% compared to head (f3d35b1) 91.00%.
Report is 5 commits behind head on main.

❗ Current head f3d35b1 differs from pull request most recent head 04d2ee9. Consider uploading reports for the commit 04d2ee9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6128      +/-   ##
============================================
- Coverage     91.03%   91.00%   -0.04%     
- Complexity     5648     5702      +54     
============================================
  Files           619      630      +11     
  Lines         16443    16710     +267     
  Branches       1663     1656       -7     
============================================
+ Hits          14969    15207     +238     
- Misses         1010     1047      +37     
+ Partials        464      456       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch from 3faa43f to 001333b Compare January 9, 2024 00:14
@codefromthecrypt
Copy link
Contributor

#6129 properly addresses this. Compile glitches were missed due to bom import order

@renovate renovate bot force-pushed the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch from 001333b to f3d35b1 Compare January 10, 2024 01:41
@renovate renovate bot changed the title Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3 Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3 - autoclosed Jan 12, 2024
@renovate renovate bot closed this Jan 12, 2024
@renovate renovate bot deleted the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch January 12, 2024 23:03
@renovate renovate bot changed the title Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3 - autoclosed Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3 Jan 14, 2024
@renovate renovate bot reopened this Jan 14, 2024
@renovate renovate bot restored the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch January 14, 2024 09:16
@renovate renovate bot force-pushed the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch from f3d35b1 to b918ded Compare January 14, 2024 09:16
@renovate renovate bot changed the title Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3 Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3.2.0 Jan 14, 2024
@codefromthecrypt
Copy link
Contributor

#6151 updates for this

@renovate renovate bot force-pushed the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch from b918ded to 5402e4e Compare January 14, 2024 13:18
@renovate renovate bot changed the title Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3.2.0 Update dependency io.zipkin.reporter2:zipkin-reporter-bom to v3.2.1 Jan 14, 2024
@renovate renovate bot force-pushed the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch from 5402e4e to 04d2ee9 Compare January 17, 2024 21:55
@jack-berg
Copy link
Member

Closing in favor of #6151.

@jack-berg jack-berg closed this Jan 18, 2024
Copy link
Contributor Author

renovate bot commented Jan 18, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (3.2.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/io.zipkin.reporter2-zipkin-reporter-bom-3.x branch January 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants