Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Consider moving setSpan()/getSpan() to its related subsection #40

Closed
carlosalberto opened this issue Apr 21, 2021 · 2 comments · Fixed by #47
Closed

Consider moving setSpan()/getSpan() to its related subsection #40

carlosalberto opened this issue Apr 21, 2021 · 2 comments · Fixed by #47
Assignees

Comments

@carlosalberto
Copy link

That is, that it is accessed through opentelemetry.trace instead of opentelemetry - which is followed by other SIGs, as the idea is overall having each concern have exclusive logical access to its own key/slot. Likewise for the Baggage portion.

Not a strong feeling though, as things are slightly differently organized for JS. For your consideration.

@dyladan
Copy link
Member

dyladan commented Apr 21, 2021

This was done in order to be friendlier to automatic minifiers (important for browser uses). trace.getSpan can only be minified to a.getSpan where getSpan can be minified to a single letter function.

@vmarchaud
Copy link
Member

We discussed this at SIG and we decided that the understability outweight the minification issue, i'll update all the top level helpers to be on each API namespace

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants