Skip to content

Commit

Permalink
chore(tedious) align supported versions in code tests and docs (#1655)
Browse files Browse the repository at this point in the history
  • Loading branch information
blumamir committed Aug 30, 2023
1 parent 67f66d2 commit 0b1f5b6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-tedious/.tav.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
tedious:
# 4.0.0 is broken: https://github.com/tediousjs/tedious/commit/4eceb48
versions: "1.11.0 || 1.14.0 || 2.7.1 || 3.0.1 || 4.2.0 || ^6.7.0 || 8.3.0 || 9.2.3 || 11.0.9 || 11.2.0 || 11.4.0 || ^11.8.0 || ^12.3.0 || ^13.2.0 || ^14.0.0"
versions: "1.11.0 || 1.14.0 || 2.7.1 || 3.0.1 || 4.2.0 || ^6.7.0 || 8.3.0 || 9.2.3 || 11.0.9 || 11.2.0 || 11.4.0 || ^11.8.0 || ^12.3.0 || ^13.2.0 || ^14.0.0 || ^15.0.0"
commands: npm run test

# Fix missing `test-utils` package
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-tedious/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-tedious

## Supported Versions

- `>=1.11.0`
- `>=1.11.0 <=15`

## Usage

Expand Down
4 changes: 2 additions & 2 deletions plugins/node/instrumentation-tedious/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@
"mocha": "7.2.0",
"nyc": "15.1.0",
"rimraf": "5.0.1",
"tedious": "14.1.0",
"tedious": "15.1.3",
"test-all-versions": "5.0.1",
"ts-mocha": "10.0.0",
"typescript": "4.4.4"
},
"dependencies": {
"@opentelemetry/instrumentation": "^0.41.2",
"@opentelemetry/semantic-conventions": "^1.0.0",
"@types/tedious": "^4.0.6"
"@types/tedious": "^4.0.10"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-tedious#readme"
}
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class TediousInstrumentation extends InstrumentationBase<
return [
new InstrumentationNodeModuleDefinition<typeof tedious>(
TediousInstrumentation.COMPONENT,
['*'],
['>=1.11.0 <=15'],
(moduleExports: any, moduleVersion) => {
this._diag.debug(`Patching tedious@${moduleVersion}`);

Expand Down

0 comments on commit 0b1f5b6

Please sign in to comment.