Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tedious): align supported versions in code tests and docs #1655

Merged
merged 3 commits into from Aug 30, 2023

Conversation

blumamir
Copy link
Member

Tedious instrumentation has some inconsistencies with it's supported range of versions.

  • It claims to support all tedious versions (*) which is something we want to avoid, as new major versions might introduce breaking changes for which the instrumentation is not prepared and might potentially harm end users' app stability
  • It does not include new versions in tav which means the instrumentation will attempt patching for versions for which we never run a test to verify compatibility.
  • The supported versions range in docs is not the same as what's in the code.

This PR fixes those 3 issues.

As for August 2023, tedious have a new major version 16, which dropped support for node 14, thus we are unable to run our CI tests properly on it. I attempted to fix this in #1638 , but since mssql does not publish docker version for my mac apple chip, I am not able to run the test locally.

I will document this in an issue and wait for us to drop node14 support or for someone with motivation to pick this up and fix the tests so the CI is green.

@blumamir blumamir requested a review from a team as a code owner August 29, 2023 06:32
@github-actions github-actions bot requested a review from rauno56 August 29, 2023 06:32
@blumamir blumamir changed the title chore(tedious) align supported versions in code tests and docs chore(tedious): align supported versions in code tests and docs Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1655 (c511ba6) into main (67f66d2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1655   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         129      129           
  Lines        6389     6389           
  Branches     1277     1277           
=======================================
  Hits         5838     5838           
  Misses        551      551           
Files Changed Coverage Δ
...ode/instrumentation-tedious/src/instrumentation.ts 92.47% <ø> (ø)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@blumamir blumamir merged commit 0b1f5b6 into open-telemetry:main Aug 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants