Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update otel core experimental to ^0.38.0 - autoclosed #1459

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Apr 5, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@opentelemetry/instrumentation (source) ^0.35.1 -> ^0.38.0 age adoption passing confidence
@opentelemetry/instrumentation (source) ^0.32.0 -> ^0.38.0 age adoption passing confidence
@opentelemetry/instrumentation-fetch (source) ^0.35.1 -> ^0.38.0 age adoption passing confidence
@opentelemetry/instrumentation-grpc (source) ^0.35.1 -> ^0.38.0 age adoption passing confidence
@opentelemetry/instrumentation-http (source) ^0.32.0 -> ^0.38.0 age adoption passing confidence
@opentelemetry/instrumentation-http (source) 0.35.1 -> 0.38.0 age adoption passing confidence
@opentelemetry/instrumentation-http (source) ^0.35.1 -> ^0.38.0 age adoption passing confidence
@opentelemetry/instrumentation-xml-http-request (source) ^0.35.1 -> ^0.38.0 age adoption passing confidence
@opentelemetry/sdk-node (source) ^0.37.0 -> ^0.38.0 age adoption passing confidence

Release Notes

open-telemetry/opentelemetry-js

v0.38.0

Compare Source

v0.37.0

Compare Source

v0.36.1

Compare Source

v0.36.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner April 5, 2023 09:15
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Apr 5, 2023
@Flarna
Copy link
Member

Flarna commented Apr 5, 2023

Seems like some update in core repo breaks at least tests here.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1459 (2845d71) into main (d2d8288) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          14       14           
  Lines         906      906           
  Branches      197      197           
=======================================
  Hits          871      871           
  Misses         35       35           

@dyladan
Copy link
Member

dyladan commented Apr 5, 2023

Looks like the test failures are a timeout in the instana detector. @kirrg001 @basti1302 can you check that out?

@renovate-bot renovate-bot force-pushed the renovate/otel-core-experimental branch from a52b001 to 8ebd6a3 Compare April 5, 2023 21:06
@kirrg001
Copy link
Contributor

kirrg001 commented Apr 6, 2023

Refs:

Deprecated detectResources() in favor of a new method detectResourcesSync() which defers promises into the resource to be resolved later

They have introduced a breaking change. detectResources is no longer async.

Instead they have introduced:

await resource.waitForAsyncAttributes?.();

All detectors use await sdk.detectResources in their README.

I will update README and adapt the integration test, which has catched the problem.

@kirrg001
Copy link
Contributor

kirrg001 commented Apr 6, 2023

@dyladan See #1462. I do not have write permissions for the renovate remote.

@renovate-bot renovate-bot force-pushed the renovate/otel-core-experimental branch 2 times, most recently from 40fe172 to 6732929 Compare April 12, 2023 10:48
@Flarna
Copy link
Member

Flarna commented Apr 12, 2023

Unfortunately there seem to be a few more components which are not compatible anymore with latest Otel core...

@renovate-bot renovate-bot changed the title fix(deps): update otel core experimental to ^0.37.0 fix(deps): update otel core experimental to ^0.38.0 Apr 13, 2023
@renovate-bot renovate-bot force-pushed the renovate/otel-core-experimental branch from 6732929 to 2845d71 Compare April 13, 2023 18:56
@renovate-bot renovate-bot changed the title fix(deps): update otel core experimental to ^0.38.0 fix(deps): update otel core experimental to ^0.38.0 - autoclosed Apr 24, 2023
@renovate-bot renovate-bot deleted the renovate/otel-core-experimental branch April 24, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants