chore(detectors/node): adapted breaking change in @opentelemetry/sdk-node@0.37.0 #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
+ Coverage 96.13% 96.49% +0.35%
==========================================
Files 14 2 -12
Lines 906 57 -849
Branches 197 9 -188
==========================================
- Hits 871 55 -816
+ Misses 35 2 -33
|
Flarna
approved these changes
Apr 6, 2023
|
An alternative would be that you cherry pick the commit from renovate and add you fix on top of it. |
dyladan
reviewed
Apr 6, 2023
detectors/node/opentelemetry-resource-detector-instana/README.md
Outdated
Show resolved
Hide resolved
kirrg001
force-pushed
the
fix-detectors/sdknode037
branch
from
6375a86
to
079dedd
Compare
Flarna
reviewed
Apr 11, 2023
detectors/node/opentelemetry-resource-detector-instana/README.md
Outdated
Show resolved
Hide resolved
kirrg001
force-pushed
the
fix-detectors/sdknode037
branch
from
079dedd
to
385b777
Compare
…node@0.37.0 - open-telemetry/opentelemetry-js#3460 - Deprecated detectResources() in favor of a new method detectResourcesSync() which defers promises into the resource to be resolved later - introduced await resource.waitForAsyncAttributes?.();
kirrg001
force-pushed
the
fix-detectors/sdknode037
branch
from
385b777
to
9b31a5f
Compare
Yes it is an organization. This is not supported. |
|
At least in the past it was possible to allow it per PR, see here. In general I recommend a personal fork but I know that companies often don't allow this. |
pichlermarc
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1459 (comment)
I do no have write permissions for renovate-bot:renovate/otel-core-experimental.
Feel free to close this PR and cherry-pick the commit.
The README files for all detectors needs to be updated too. Let me know if you want me to update them too.