-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instr-express): add semconv to readme #1907
chore(instr-express): add semconv to readme #1907
Conversation
As mentioned on the issue, I'm hoping to get feedback on this to see if it satisfies the goals of #1778 or if there are pieces to this that are missing. For example, I'm not sure if attributes listed are intended to just be those from semantic conventions, or if all attributes on an instrumented Express span should be listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
+ Coverage 91.02% 91.04% +0.01%
==========================================
Files 146 147 +1
Lines 7491 7530 +39
Branches 1501 1507 +6
==========================================
+ Hits 6819 6856 +37
- Misses 672 674 +2 |
I think the goal there is to just to the actual semconv ones, so this PR satisfies the goals of that issue 🙂 |
Which problem is this PR solving?
Short description of the changes