chore: attempt to prevent non-releasing packages from being included in release-please release PRs #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in release-please release PRs This continues on from open-telemetry#1928. The non-releasing packages are being added to the release-please manifest in the hope that this prevents them from being listed in the set of released packages in a release-please PR. This is effectively Option 1b from open-telemetry#1917.
github-actions
bot
assigned blumamir, haddasbronfman, JamieDanielson, osherv, pkanal and seemk
github-actions
bot
requested review from
blumamir,
haddasbronfman,
JamieDanielson,
osherv,
pkanal and
seemk
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 146 146
Lines 7478 7478
Branches 1497 1497
=======================================
Hits 6807 6807
Misses 671 671 |
pichlermarc
approved these changes
Feb 15, 2024
This was referenced Feb 15, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on from #1928. The non-releasing packages are being added to the
release-please manifest in the hope that this prevents them from being listed
in the set of released packages in a release-please PR. This is
effectively Option 1b from #1917.
/cc @pichlermarc
I chose to reset the version for all the examples packages to "0.1.0" to just have a static common value. Some of them had attempted to track the matching instrumentation version, but many of them didn't keep up, so I think the "version" field on the examples packages is just misleading.
I did not change the version on the sampler-aws-xray package in case there is some user that happened to be using it when installing the package manually from the repo dir.
The effective manifest diff is this: