-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency superagent to v9 #2175
chore(deps): update dependency superagent to v9 #2175
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
==========================================
- Coverage 90.97% 90.37% -0.61%
==========================================
Files 146 147 +1
Lines 7492 7500 +8
Branches 1502 1569 +67
==========================================
- Hits 6816 6778 -38
- Misses 676 722 +46 |
@@ -51,7 +51,7 @@ | |||
"nyc": "15.1.0", | |||
"rimraf": "5.0.5", | |||
"semver": "^7.6.0", | |||
"superagent": "8.0.9", | |||
"superagent": "9.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this dependency being used anywhere.
@david-luna is it safe to remove it? or am I missing anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that must be a leftover from the initial commit where I used a package.json
from another instrumentation as a template. We can close this PR and I'm going to create a PR to remove it ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look, opened #2239 as a replacement
eee90ae
to
d0c7c18
Compare
close in favor of #2239 |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
8.0.9
->9.0.2
Release Notes
ladjs/superagent (superagent)
v9.0.2
Compare Source
329cc63
url.parse()
withnew URL()
8ead63f
9406dae
86c9bf4
e996382
node:url
methods7e20ced
v9.0.1
Compare Source
68f7bb1
450f7b2
ea633d7
e334068
a5c39b2
0165c7c
polyfill.io
da9ff20
c4205e0
v9.0.0
Compare Source
489708e
ea2577e
23fe5ab
03de30c
b9c7837
3ee138d
1c8338b
0dc80d1
83e92cb
fca95a3
v8.1.2
Compare Source
b83887a
36088a6
v8.1.1
Compare Source
6feca3f
v8.1.0
Compare Source
8b5400b
2fd4292
a29a062
a62866a
4691583
req.destroyed = true
on abort70c464c
259a43f
ef969fa
7801408
73c7efb
988636f
Configuration
📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.