-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update last deprecated usages of semantic-conventions pkg #2210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
- Coverage 90.97% 90.37% -0.61%
==========================================
Files 146 147 +1
Lines 7492 7500 +8
Branches 1502 1569 +67
==========================================
- Hits 6816 6778 -38
- Misses 676 722 +46 |
ping @maryliag @JamieDanielson. I'd appreciate a review on this. This is the last of changing over to the new semconv package usage in the contrib repo. (I.e. I think we can close #2025 after this.) |
@trentm I had already approved a couple of hours ago, but hopefully Jamie can provide another so you can merge |
Oh duh, thanks. I hadn't refreshed this page before pinging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment about resource-assertions in the test-utils package, but it's not blocking because of the package it's in, and would be okay to revisit in a follow-up if needed. It would be good to get that issue closed.
Refs: #2025
This updates the last uses (in READMEs and test files) of the deprecated exports from the semantic-conventions package for #2025 -- with the exception of a usage in "archive/...".