Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove redundant migration text from READMEs #2243

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented May 25, 2024

instrumentations aws-sdk, mongoose and amqplib where originally hosted in aspect repo https://github.com/aspecto-io/opentelemetry-ext-js

When upstreaming them to the contrib repo, I added migration instructions for people who might be migrating from the old to the new package.

Since few years has pass, I think this info is no longer relevant or needed in the README

@blumamir blumamir requested a review from a team as a code owner May 25, 2024 08:05
@blumamir blumamir changed the title docs: remove redundant migration text docs: remove redundant migration text from READMEs May 25, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (dfb2dff) to head (1353f47).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
- Coverage   90.97%   90.30%   -0.68%     
==========================================
  Files         146      147       +1     
  Lines        7492     7263     -229     
  Branches     1502     1509       +7     
==========================================
- Hits         6816     6559     -257     
- Misses        676      704      +28     

see 57 files with indirect coverage changes

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pichlermarc
Copy link
Member

LGTM.

Should instr-socket.io be done as well? https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/instrumentation-socket.io/README.md#migration-from-opentelemetry-instrumentation-socketio

Yes, I think we should also do the same to that package.

@blumamir
Copy link
Member Author

@blumamir blumamir merged commit 1ac1045 into open-telemetry:main Jun 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants