fix: multi span processor should flush child span processors (#1024)

open-telemetry · May 6, 2020 · 2b14af3 · 2b14af3
1 parent c1bcce8
commit 2b14af3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/opentelemetry-tracing/src/MultiSpanProcessor.ts b/packages/opentelemetry-tracing/src/MultiSpanProcessor.ts
@@ -25,7 +25,9 @@ export class MultiSpanProcessor implements SpanProcessor {
   constructor(private readonly _spanProcessors: SpanProcessor[]) {}
 
   forceFlush(): void {
-    // do nothing as all spans are being exported without waiting
+    for (const spanProcessor of this._spanProcessors) {
+      spanProcessor.forceFlush();
+    }
   }
 
   onStart(span: Span): void {

diff --git a/packages/opentelemetry-tracing/test/MultiSpanProcessor.test.ts b/packages/opentelemetry-tracing/test/MultiSpanProcessor.test.ts
@@ -65,4 +65,19 @@ describe('MultiSpanProcessor', () => {
     assert.strictEqual(processor1.spans.length, 0);
     assert.strictEqual(processor1.spans.length, processor2.spans.length);
   });
+
+  it('should force span processors to flush', () => {
+    let flushed = false;
+    const processor: SpanProcessor = {
+      forceFlush: () => {
+        flushed = true;
+      },
+      onStart: span => {},
+      onEnd: span => {},
+      shutdown: () => {},
+    };
+    const multiSpanProcessor = new MultiSpanProcessor([processor]);
+    multiSpanProcessor.forceFlush();
+    assert.ok(flushed);
+  });
 });