Merge branch 'main' into remove-http-route-from-attributes

open-telemetry · Sep 27, 2021 · 543b245 · 543b245
2 parents 5e7cd47 + 33935e7
commit 543b245
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts b/packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts
@@ -72,7 +72,6 @@ describe('OTLPMetricExporter - node with json over http', () => {
       // Need to stub/spy on the underlying logger as the "diag" instance is global
       const spyLoggerWarn = sinon.stub(diag, 'warn');
       collectorExporter = new OTLPMetricExporter({
-        serviceName: 'basic-service',
         url: address,
         metadata,
       } as any);

diff --git a/packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts b/packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts
@@ -58,7 +58,6 @@ describe('OTLPTraceExporter - node with json over http', () => {
       // Need to stub/spy on the underlying logger as the "diag" instance is global
       const spyLoggerWarn = sinon.stub(diag, 'warn');
       collectorExporter = new OTLPTraceExporter({
-        serviceName: 'basic-service',
         metadata,
         url: address,
       } as any);