fix: use Object.entries in lieu of for...in to ensure we are iteratin…

…g own properties only Signed-off-by: Naseem <naseem@transit.app>
open-telemetry · Sep 11, 2020 · 6570984 · 6570984
1 parent f4624b0
commit 6570984
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/opentelemetry-core/src/utils/deep-merge.ts b/packages/opentelemetry-core/src/utils/deep-merge.ts
@@ -22,14 +22,14 @@ export function deepMerge(
   if (maxDepth === 0) {
     throw new Error('Max depth exceeded.');
   }
-  for (const prop in source) {
+  for (const [prop, value] of Object.entries(source)) {
     if (bothPropsAreArrays(target, source, prop)) {
       merged[prop] = [];
-      merged[prop] = source[prop];
+      merged[prop] = value;
     } else if (bothPropsAreObjects(target, source, prop)) {
-      merged[prop] = deepMerge(target[prop], source[prop], maxDepth - 1);
+      merged[prop] = deepMerge(target[prop], value, maxDepth - 1);
     } else {
-      merged[prop] = source[prop];
+      merged[prop] = value;
     }
   }
   return merged;