chore: remove ordered attribute dropping

open-telemetry · Nov 18, 2020 · 75672cb · 75672cb
1 parent 7242c76
commit 75672cb
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/packages/opentelemetry-tracing/src/Span.ts b/packages/opentelemetry-tracing/src/Span.ts
@@ -103,15 +103,10 @@ export class Span implements api.Span, ReadableSpan {
 
     if (
       Object.keys(this.attributes).length >=
-      this._traceParams.numberOfAttributesPerSpan!
+        this._traceParams.numberOfAttributesPerSpan! &&
+      !Object.prototype.hasOwnProperty.call(this.attributes, key)
     ) {
-      const attributeKeyToDelete = Object.keys(this.attributes).shift();
-      if (attributeKeyToDelete) {
-        this._logger.warn(
-          `Dropping extra attributes : ${attributeKeyToDelete}`
-        );
-        delete this.attributes[attributeKeyToDelete];
-      }
+      return this;
     }
     this.attributes[key] = value;
     return this;