Skip to content

Commit

Permalink
refactor(experimental/examples/opencensus-shim): use new exported str…
Browse files Browse the repository at this point in the history
…ing constants for semconv (#4763)

* refactor(experimental/examples/opencensus-shim): use new exported string constants for semconv

* added changelog entry (experimental)
  • Loading branch information
Zen-cronic committed Jun 5, 2024
1 parent 9cd2021 commit 97f372b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ All notable changes to experimental packages in this project will be documented

* docs(instrumentation): better docs for supportedVersions option [#4693](https://github.com/open-telemetry/opentelemetry-js/pull/4693) @blumamir
* docs: align all supported versions to a common format [#4696](https://github.com/open-telemetry/opentelemetry-js/pull/4696) @blumamir
* refactor(examples): use new exported string constants for semconv in experimental/examples/opencensus-shim [#4763](https://github.com/open-telemetry/opentelemetry-js/pull/4763#pull) @Zen-cronic

### :house: (Internal)

Expand Down
4 changes: 2 additions & 2 deletions experimental/examples/opencensus-shim/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const {
const { PrometheusExporter } = require('@opentelemetry/exporter-prometheus');
const { Resource } = require('@opentelemetry/resources');
const {
SemanticResourceAttributes,
SEMRESATTRS_SERVICE_NAME,
} = require('@opentelemetry/semantic-conventions');
const { OpenCensusMetricProducer } = require('@opentelemetry/shim-opencensus');
const instrumentationHttp = require('@opencensus/instrumentation-http');
Expand All @@ -46,7 +46,7 @@ module.exports = function setup(serviceName) {
tracing.tracer = new oc.CoreTracer();

const resource = new Resource({
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
[SEMRESATTRS_SERVICE_NAME]: serviceName,
});
const tracerProvider = new NodeTracerProvider({ resource });
tracerProvider.addSpanProcessor(
Expand Down

0 comments on commit 97f372b

Please sign in to comment.