-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow capturing database query params #1044
Allow capturing database query params #1044
Comments
Thanks for opening the issue! If you are feeling motivated, maybe you can attempt to write solution and open a PR. The @dyladan WDYT? |
I think that's a great idea. Would also be nice to decide and document exactly what "enhanced" db reporting means so all plugins can be consistent. |
Assigning @romilpunetha because he mentioned in Gitter he wanted to take a crack at this. I'm also assigning myself so I can help shepherd his first contribution. :) |
…sage (open-telemetry#1044) * fix(instrumentation-aws-sdk): dedupe prop fields Co-authored-by: Kent Quirk <kentquirk@users.noreply.github.com> Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com> Co-authored-by: Mike Goldsmith <mikegoldsmith@users.noreply.github.com> * fix linting * add test for message attributes Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com> * test both messages * deduplicate message attribute names in seperate function and add unit tests Co-authored-by: Jamie Danielson <JamieDanielson@users.noreply.github.com> * remove line to force ci checks * appease linter Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com> * appease linter * move logic into dedupe function and add unit tests * rename helper function to be more descriptive Co-authored-by: Kent Quirk <kentquirk@users.noreply.github.com> Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com> Co-authored-by: Mike Goldsmith <mikegoldsmith@users.noreply.github.com> Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com> Co-authored-by: Purvi Kanal <purvikanal@honeycomb.io> Co-authored-by: Jamie Danielson <JamieDanielson@users.noreply.github.com> Co-authored-by: Purvi Kanal <kanal.purvi@gmail.com>
Is your feature request related to a problem? Please describe.
It would be helpful to have entire DB query populated with parameters for easy debugging. Vendors such as datadog cannot do this for security reasons.
Describe the solution you'd like
A flag that allows enabling capturing Db query parameters. Enabling this in envs such as stage could be really beneficial sometimes. A self hosted solution should have this as a configuration. Nodejs plugin interface already has a
enhancedDatabaseReporting
flag, which I don't think is used.Describe alternatives you've considered
Log the entire db query.
The text was updated successfully, but these errors were encountered: