Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow capturing database query params #1044

Closed
ghost opened this issue May 11, 2020 · 3 comments · Fixed by open-telemetry/opentelemetry-js-contrib#34
Closed

Allow capturing database query params #1044

ghost opened this issue May 11, 2020 · 3 comments · Fixed by open-telemetry/opentelemetry-js-contrib#34
Assignees

Comments

@ghost
Copy link

ghost commented May 11, 2020

Is your feature request related to a problem? Please describe.
It would be helpful to have entire DB query populated with parameters for easy debugging. Vendors such as datadog cannot do this for security reasons.

Describe the solution you'd like
A flag that allows enabling capturing Db query parameters. Enabling this in envs such as stage could be really beneficial sometimes. A self hosted solution should have this as a configuration. Nodejs plugin interface already has a enhancedDatabaseReporting flag, which I don't think is used.

Describe alternatives you've considered
Log the entire db query.

@ghost ghost added the feature-request label May 11, 2020
@mayurkale22
Copy link
Member

Thanks for opening the issue!

If you are feeling motivated, maybe you can attempt to write solution and open a PR. The enhancedDatabaseReporting flag is designed to expose additional information like query parameters and results about database operations.

@dyladan WDYT?

@dyladan
Copy link
Member

dyladan commented May 11, 2020

I think that's a great idea. Would also be nice to decide and document exactly what "enhanced" db reporting means so all plugins can be consistent.

@dyladan dyladan assigned dyladan and ghost May 12, 2020
@dyladan
Copy link
Member

dyladan commented May 12, 2020

Assigning @romilpunetha because he mentioned in Gitter he wanted to take a crack at this. I'm also assigning myself so I can help shepherd his first contribution. :)

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
…sage (open-telemetry#1044)

* fix(instrumentation-aws-sdk): dedupe prop fields

Co-authored-by: Kent Quirk <kentquirk@users.noreply.github.com>
Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com>
Co-authored-by: Mike Goldsmith <mikegoldsmith@users.noreply.github.com>

* fix linting

* add test for message attributes

Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com>

* test both messages

* deduplicate message attribute names in seperate function and add unit tests

Co-authored-by: Jamie Danielson <JamieDanielson@users.noreply.github.com>

* remove line to force ci checks

* appease linter

Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com>

* appease linter

* move logic into dedupe function and add unit tests

* rename helper function to be more descriptive

Co-authored-by: Kent Quirk <kentquirk@users.noreply.github.com>
Co-authored-by: Purvi Kanal <pkanal@users.noreply.github.com>
Co-authored-by: Mike Goldsmith <mikegoldsmith@users.noreply.github.com>
Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
Co-authored-by: Purvi Kanal <purvikanal@honeycomb.io>
Co-authored-by: Jamie Danielson <JamieDanielson@users.noreply.github.com>
Co-authored-by: Purvi Kanal <kanal.purvi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants