Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove labelKeys from metric creation #1119

Closed
dyladan opened this issue May 27, 2020 · 5 comments
Closed

Remove labelKeys from metric creation #1119

dyladan opened this issue May 27, 2020 · 5 comments
Assignees
@naseemkullah
Labels
feature-request

Comments

@dyladan
Copy link
Member

dyladan commented May 27, 2020

The labelKeys input to the metric was removed from the spec. I don't have any spec to link to because it is gone :)

This is not removing labels, just removing the labelKeys input to the instrument construction.
@naseemkullah naseemkullah mentioned this issue May 31, 2020
Merged
@naseemkullah
Copy link
Member

🙋‍♂️

@naseemkullah
Copy link
Member

The purpose of labelKeys was to choose what labels would be added to a metric among the available labels right?
Is that to say there is no way to filter/remove which labels will wind up in the metric now?

@naseemkullah
Copy link
Member

#1126 opened

@mayurkale22
Copy link
Member

I think open-telemetry/opentelemetry-specification#565 is the specs PR.

@naseemkullah naseemkullah mentioned this issue Jun 1, 2020
Closed
6 tasks
@mayurkale22
Copy link
Member

Closed via #1126

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@unflxw
fix(koa): ignore generator-based Koa middleware (open-telemetry#1119)
6684b56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naseemkullah naseemkullah

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dyladan @mayurkale22 @naseemkullah