Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: No explicit parent Span/SpanReference allowed #1611

Closed
dyladan opened this issue Oct 21, 2020 · 1 comment · Fixed by #1612
Closed

Spec: No explicit parent Span/SpanReference allowed #1611

dyladan opened this issue Oct 21, 2020 · 1 comment · Fixed by #1612
Assignees
@dyladan
Labels
feature-request
Projects
GA Burndown

Comments

@dyladan
Copy link
Member

dyladan commented Oct 21, 2020

According to https://github.com/open-telemetry/opentelemetry-specification/blob/662baae949f01a8ecc950426bf09283be1b657de/specification/trace/api.md#span-creation, the only way to specify parent is using the context object. Explicit parent option is no longer allowed.
@dyladan dyladan self-assigned this Oct 21, 2020
@dyladan dyladan added this to To do issues in GA Burndown via automation Oct 21, 2020
@dyladan dyladan mentioned this issue Oct 21, 2020
Merged
@vmarchaud
Copy link
Member

vmarchaud commented Oct 21, 2020 •
edited
Loading

I had already opened one here #1552 but if you have time to work on this i'll be happy to close the older one

EDIT: I see you opened a PR, i'll close the old one

@vmarchaud vmarchaud mentioned this issue Oct 21, 2020
Closed
GA Burndown automation moved this from To do issues to Done Nov 2, 2020
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan @pichlermarc
fix: Revert "feat(minification): Add importHelpers and tslib as a dep…
e5bca5f 
…endency (open-telemetry#1545)" (open-telemetry#1611)

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
@dyladan @pichlermarc
fix: Revert "feat(minification): Add importHelpers and tslib as a dep…
633de2e 
…endency (open-telemetry#1545)" (open-telemetry#1611)

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 16, 2024
@dyladan @pichlermarc
fix: Revert "feat(minification): Add importHelpers and tslib as a dep…
2d0ebc1 
…endency (open-telemetry#1545)" (open-telemetry#1611)

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
feature-request
Projects
No open projects
GA Burndown
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove explicit parent option dynatrace-oss-contrib/opentelemetry-js
2 participants
@dyladan @vmarchaud