Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP integration tests are too flaky #1799

Closed
dyladan opened this issue Jan 8, 2021 · 2 comments
Closed

HTTP integration tests are too flaky #1799

dyladan opened this issue Jan 8, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@dyladan
Copy link
Member

dyladan commented Jan 8, 2021

The http instrumentation tests are so flaky at this point that I am seeing failures on at least one of the node versions for almost every PR. The instrumentation tests currently reach out to the real internet and test a variety of features already covered by unit tests. I think we should drastically simplify any http testing which requires async requests to just a single representative example which uses the most common features. Other things are, or should be, sufficiently covered by unit tests.

@dyladan dyladan added the bug Something isn't working label Jan 8, 2021
@vmarchaud
Copy link
Member

vmarchaud commented Jan 10, 2021

not sure why the tests are specially flaky with the instrumentation (instead of the plugin).

I'm not sure why we have integration tests (either with 3rd parties modules or that reach internet), i don't see any benefits since unit test covers both the server and client quite fine. Plus testing 3rd party modules that use the core http module anyway seems redundant.

@dyladan
Copy link
Member Author

dyladan commented Jan 11, 2021

Fixed in #1808

@dyladan dyladan closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants