chore: use local server for http integration tests #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
dyladan
force-pushed
the
local-integration
branch
from
74b992b
to
4efef15
Compare
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
+ Coverage 92.45% 92.49% +0.03%
==========================================
Files 173 173
Lines 6019 6019
Branches 1287 1287
==========================================
+ Hits 5565 5567 +2
+ Misses 454 452 -2
|
Flarna
reviewed
Jan 11, 2021
packages/opentelemetry-instrumentation-http/test/integrations/http-enable.test.ts
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Jan 11, 2021
packages/opentelemetry-instrumentation-http/test/integrations/http-enable.test.ts
Outdated
Show resolved
Hide resolved
|
@vmarchaud I believe this will address the test flakiness but I would appreciate a look |
obecny
reviewed
Jan 11, 2021
packages/opentelemetry-instrumentation-http/test/integrations/http-enable.test.ts
Show resolved
Hide resolved
vmarchaud
approved these changes
Jan 11, 2021
|
@dyladan Thanks for taking the time to do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the flakiness of the http test comes down to its dependence on making requests to google.fr. I have replaced this functionality in the tests with a local dev server. Making these requests locally means they are faster and more reliable.