Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Context-* package and implementation #46

Closed
mayurkale22 opened this issue Jun 19, 2019 · 3 comments
Closed

Add Context-* package and implementation #46

mayurkale22 opened this issue Jun 19, 2019 · 3 comments
Assignees

Comments

@mayurkale22
Copy link
Member

Add separate packages for Context Propagation/Continues Local Storage (CLS). The primary objective of CLS is to implement a transparent context API, that is, we don't need to pass around a ctx variable everywhere in application code.

In today's (06-19-19) SIG meeting, we have decided to implement generic API, so that it can be used outside OpenTelemetry project.

opentelemetry/context-base
The base implementation that doesn't propagate the context, but handles things like binding.

opentelemetry/context-async-hooks
Implement Async Hooks - async_hooks (since we will be targeting Node 8+).

OpenTracing work on ScopeManager: opentracing/opentracing-javascript#113

OpenCensus work: https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-core/src/internal/cls-ah.ts

@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 20, 2019
@mayurkale22
Copy link
Member Author

Assigned to @vmarchaud as per offline discussion, Thanks for the initiative and help.

vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jun 26, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jun 27, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jun 27, 2019
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 28, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 4, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 4, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 8, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 8, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 8, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 10, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jul 11, 2019
mayurkale22 pushed a commit that referenced this issue Jul 11, 2019
* Add context-base and context-asynchooks packages

* add BaseScopeManager interface #46
@vmarchaud
Copy link
Member

I think this issue can be closed since both implementation have been merged

@mayurkale22
Copy link
Member Author

Sure, thanks @vmarchaud for the PRs to close this.

dyladan pushed a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
* Add context-base and context-asynchooks packages

* add BaseScopeManager interface open-telemetry#46
dyladan added a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants