Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default log level #578

Closed
naseemkullah opened this issue Nov 29, 2019 · 7 comments · Fixed by #856
Closed

Default log level #578

naseemkullah opened this issue Nov 29, 2019 · 7 comments · Fixed by #856
Assignees

Comments

@naseemkullah
Copy link
Member

naseemkullah commented Nov 29, 2019

Hello I recently instrumented a process that makes many queries to 3rd party apis. I used the http and dns plugins. My log sink is being flooded with noise. What is the suggested approach? I am using default sampling rate and Jaeger exporter.

@naseemkullah
Copy link
Member Author

I've adjusted the tracer's logLevel: opentelemetry.LogLevel.ERROR as per the getting started guide.

@naseemkullah
Copy link
Member Author

Should we maybe make the default log level info ?

@naseemkullah naseemkullah reopened this Nov 30, 2019
@naseemkullah naseemkullah changed the title Instrumentation is flooding log sink Default log level Nov 30, 2019
@mayurkale22
Copy link
Member

The current default LogLevel is DEBUG and default Logger is ConsoleLogger, maybe we can change ConsoleLogger -> NoopLogger or DEBUG -> ERROR.

@naseemkullah
Copy link
Member Author

naseemkullah commented Dec 1, 2019

Is there documentation about the use case between ConsoleLogger and NoopLogger? I take it the name should be self explanatory but I am still unsure.

Furthermore, would there be any benefit to have structured logging for error logs in production in particular, and if so would it be alright to implement this via pino?

@vmarchaud
Copy link
Member

@naseemkullah
ConsoleLogger logs to the console and NoopLogger doesn't do anything, i don't think we have specific documentation yet though.

There are always benefit having more implementation of our API to better suit end-users way of doing so i guess we could have a dedicated package PinoLogger which implement structured logging.

@naseemkullah
Copy link
Member Author

Thanks for explaining @vmarchaud , a JsonLogger might be nice, good to know we can add it in the future.

@dyladan
Copy link
Member

dyladan commented Dec 4, 2019

Per SIG this will be changed to INFO when we go from alpha to beta. add examples for override

@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Dec 5, 2019
@bg451 bg451 self-assigned this Feb 5, 2020
@mayurkale22 mayurkale22 removed this from the Alpha v0.4 milestone Feb 12, 2020
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Mar 13, 2020
closes open-telemetry#578

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini self-assigned this Mar 13, 2020
mayurkale22 pushed a commit that referenced this issue Mar 13, 2020
* fix: change loglevel for beta

closes #578

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* test: update to  new default LogLevel

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants