Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading version inside code #600

Closed
obecny opened this issue Dec 9, 2019 · 7 comments · Fixed by #651
Closed

Reading version inside code #600

obecny opened this issue Dec 9, 2019 · 7 comments · Fixed by #651
Assignees
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Milestone

Comments

@obecny
Copy link
Member

obecny commented Dec 9, 2019

There is a problem with getting version of package inside code. Using directly package.json works fine for node but for web it will always raise an error. This is because build version and source will have a different path to package.json.
The solution done for core works fine


I want to implement a script that will be generating the version for each of package to have consistency across all packages.

@obecny
Copy link
Member Author

obecny commented Dec 9, 2019

@open-telemetry/javascript-approvers

@obecny
Copy link
Member Author

obecny commented Dec 9, 2019

@draffensperger ^^

@mayurkale22 mayurkale22 added the Discussion Issue or PR that needs/is extended discussion. label Dec 9, 2019
@mayurkale22
Copy link
Member

I want to implement a script that will be generating the version for each of package to have consistency across all packages.

Quick question: why do you want to generate version for each package, AFAIK this is only needed for core package (which we already have)?

@obecny
Copy link
Member Author

obecny commented Dec 9, 2019

We don't have now one reliable way of getting the version of certain plugin. We were discussing with @dyladan last week to have something reliable that could be similar across all packages for web and node.

@obecny
Copy link
Member Author

obecny commented Dec 9, 2019

so basically the short answer would be one script that can be used for all packages

@dyladan
Copy link
Member

dyladan commented Dec 10, 2019

@mayurkale22 the reason is because you could theoretically have a different version of core than of a plugin. The version that a plugin claims to be should not depend on another package. Right now packages are version locked together, but this may not always be the case.

@mayurkale22
Copy link
Member

Makes sense, thanks for the explanation.

@obecny obecny mentioned this issue Dec 10, 2019
@dyladan dyladan self-assigned this Dec 27, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.3.2 milestone Jan 2, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Keeps aligned with other packages in the repo.

Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants