Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dns plugin from the config #612

Closed
OlivierAlbertini opened this issue Dec 11, 2019 · 1 comment · Fixed by #613
Closed

Remove Dns plugin from the config #612

OlivierAlbertini opened this issue Dec 11, 2019 · 1 comment · Fixed by #613
Assignees
@OlivierAlbertini

Comments

@OlivierAlbertini
Copy link
Member

After v0.2, we added dns in the config file.

dns: { enabled: true, path: '@opentelemetry/plugin-dns' },

https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-node/src/config.ts

We should do that since It might require to add Dns plugin options.

For example, If we use zipkin exporter, dns need to ignore the http url otherwise we will have a loop.
For now, there is no feature that let's us fix this kind of behaviour...
@OlivierAlbertini OlivierAlbertini self-assigned this Dec 11, 2019
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Dec 11, 2019
@OlivierAlbertini
fix(plugin-dns): remove from default plugin list
b08edfe 
closes open-telemetry#612

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini mentioned this issue Dec 11, 2019
Merged
@mayurkale22
Copy link
Member

Remove DNS from the default list for 0.3.0 release
Release DNS as default when dns plugin is fixed
The short term fix would be to have users configure ignore urls
Long term fix is to share ignore urls with the exporter some way

per SIG

mayurkale22 pushed a commit that referenced this issue Dec 12, 2019
@OlivierAlbertini @mayurkale22
fix(plugin-dns): remove from default plugin list (#613)
9a91434 
closes #612

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@vmarchaud vmarchaud mentioned this issue Apr 5, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan
chore: ignore renovate-bot for component owners (open-telemetry#612)
952e6d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierAlbertini OlivierAlbertini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-dns): remove from default plugin list VilledeMontreal/opentelemetry-js
2 participants
@OlivierAlbertini @mayurkale22