New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casing of names #81

Closed

danielkhan opened this issue Jul 5, 2019 · 1 comment

Contributor

danielkhan commented Jul 5, 2019

I just saw that Event.ts and Sampler.ts are uppercase while we stick to lowercase for the rest.
Do we have a convention for that?

danielkhan added bug and removed bug labels

Member

rochdev commented Jul 5, 2019

Duplicate of #38

rochdev marked this as a duplicate of #38

rochdev closed this as completed

rochdev added the duplicate label

dyladan added a commit to dyladan/opentelemetry-js that referenced this issue


          chore: function overloads implementation of startActiveSpan in noop t… (

db3505b

open-telemetry#81)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>

dyladan added a commit to dyladan/opentelemetry-js that referenced this issue


          chore: function overloads implementation of startActiveSpan in noop t… (

67eeed1

open-telemetry#81)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment