Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@opentelemetry/metrics fails to run due to bad import #879

Closed
andybarron opened this issue Mar 19, 2020 · 7 comments · Fixed by #881
Closed

@opentelemetry/metrics fails to run due to bad import #879

andybarron opened this issue Mar 19, 2020 · 7 comments · Fixed by #881
Assignees
Labels
bug Something isn't working

Comments

@andybarron
Copy link

i have the following line in my code:

import { MeterProvider } from "@opentelemetry/metrics"

this causes my app to crash at runtime due to the following line:

import { NoopExporter } from '../test/mocks/Exporter';

it's importing from the test directory, which isn't included in the npm package, so the import can't resolve.

@dyladan dyladan added the bug Something isn't working label Mar 19, 2020
@dyladan
Copy link
Member

dyladan commented Mar 19, 2020

@mayurkale22 assigning us both to this. i'm looking into #878 right now so I would appreciate if you could take this.

@mayurkale22
Copy link
Member

Sure, looking into it now.

@mayurkale22
Copy link
Member

@andybarron Thanks for reporting this! Would be nice if you can review fix #881.

@mayurkale22
Copy link
Member

We planned to cut 0.5.1 release, once #880 is merged. Will keep you posted

@vmarchaud
Copy link
Member

vmarchaud commented Mar 19, 2020

@mayurkale22 Is it worth waiting for #873 too for releasing ? I makes the StackScopeManager is broken in its current state

@dyladan
Copy link
Member

dyladan commented Mar 19, 2020

Had hoped to get @obecny's ok on #873 before merging it. I'm ok waiting until tomorrow morning to get this out, but not much longer than that.

@dyladan
Copy link
Member

dyladan commented Mar 20, 2020

Just published 0.5.1 which should fix your issue

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants