Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: allow custom batcher for Meter #932

Closed
vmarchaud opened this issue Apr 7, 2020 · 1 comment
Closed

metrics: allow custom batcher for Meter #932

vmarchaud opened this issue Apr 7, 2020 · 1 comment
Assignees
@vmarchaud
Labels
feature-request

Comments

@vmarchaud
Copy link
Member

From the spec here, there are different type of Integrator (which is our Batcher), we should allow to define a custom one for a given meter and use UngroupedBatcher if none is provided.
It will also allow user (like me) to implement their own aggregator :)
@vmarchaud vmarchaud self-assigned this Apr 7, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Apr 7, 2020
@vmarchaud
feat(meter): allow custom batcher open-telemetry#932
30ff336
mayurkale22 added a commit that referenced this issue Apr 7, 2020
@vmarchaud @mayurkale22
feat(meter): allow custom batcher #932 (#933)
1b62c51 
Co-authored-by: Mayur Kale <mayurkale@google.com>
@mayurkale22
Copy link
Member

Closed via #933

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@Flarna
fix: avoid leaking winston types (open-telemetry#932)
31c4886 
The winston instrumentation needs the winston types only internaly.
Move them into an internal file to avoid leaking it to end user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmarchaud vmarchaud

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmarchaud @mayurkale22