Move lint and doc check to actions #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #1081 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 116 116
Lines 3396 3396
Branches 686 686
=======================================
Hits 3134 3134
Misses 262 262 |
|
@mayurkale22 one advantage of this is it uses the same version for linting that local installs do, skipping the weird hacks done by the circle ci version. Would prevent issues like what @naseemkullah is having, which is caused by a version discrepancy. |
markwolff
approved these changes
May 21, 2020
Merged
naseemkullah
approved these changes
Jun 1, 2020
|
@dyladan Looks good to merge. |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to github actions gives us more control over the caching step, which may make it easier to speed up our build process. Since the lint step is low-impact, I'm testing it here first. In the future, I would like to also introduce some release automation actions.