Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.8.2 release proposal #1092

Merged
merged 3 commits into from
May 21, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 21, 2020

Release Proposal: https://github.com/open-telemetry/opentelemetry-js/releases/tag/untagged-1edb6dac75a537decfa9

Now that #1067 is merged, I want to release this ASAP to make sure the fix is out. Until this lands, web use cases are broken.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #1092 into master will not change coverage.
The diff coverage is 21.05%.

@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         238      238           
  Lines        9085     9085           
  Branches      822      822           
=======================================
  Hits         8629     8629           
  Misses        456      456           
Impacted Files Coverage Δ
packages/opentelemetry-api/src/version.ts 0.00% <0.00%> (ø)
...s/opentelemetry-context-async-hooks/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-context-base/src/version.ts 0.00% <0.00%> (ø)
...opentelemetry-context-zone-peer-dep/src/version.ts 0.00% <0.00%> (ø)
...es/opentelemetry-exporter-collector/src/version.ts 0.00% <0.00%> (ø)
...kages/opentelemetry-exporter-jaeger/src/version.ts 0.00% <0.00%> (ø)
...s/opentelemetry-exporter-prometheus/src/version.ts 0.00% <0.00%> (ø)
...kages/opentelemetry-exporter-zipkin/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-metrics/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-node/src/version.ts 0.00% <0.00%> (ø)
... and 9 more

@dyladan
Copy link
Member Author

dyladan commented May 21, 2020

@mayurkale22 i'm going to see if i can wait for as many reviews as possible on this today, but I'd like to release this today if possible even with few reviews. Is that ok with you? Only real changes are propagator, tls for collector, and the bug fix for browsers.

@obecny
Copy link
Member

obecny commented May 21, 2020

I don't see a main package.json

@mayurkale22
Copy link
Member

@mayurkale22 i'm going to see if i can wait for as many reviews as possible on this today, but I'd like to release this today if possible even with few reviews. Is that ok with you? Only real changes are propagator, tls for collector, and the bug fix for browsers.

Big thumbs up :)

@mayurkale22
Copy link
Member

@dyladan Any idea why the codecov/patch is showing 21.05% of diff hit? Also, I assume you configured this (codecov) checks recently.

@dyladan
Copy link
Member Author

dyladan commented May 21, 2020

I did not configure this. Best guess is that this is an organization-wide thing.

@obecny
Copy link
Member

obecny commented May 21, 2020

had similar issue with even bigger different on contrib repo that's why I have checked what files are being calculated for coverage and created a new PR with updated list. But cannot guarantee it will help here too.

@dyladan
Copy link
Member Author

dyladan commented May 21, 2020

I don't see a main package.json

Seems lerna doesn't bump that one.

@dyladan
Copy link
Member Author

dyladan commented May 21, 2020

@obecny updated the main package.json

@mayurkale22 i'm going to start the release process now as I have to head out a little early today if thats ok

@mayurkale22
Copy link
Member

image

@dyladan dyladan merged commit 7233a03 into open-telemetry:master May 21, 2020
@dyladan dyladan deleted the 0.8.2-proposal branch May 21, 2020 19:18
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants