chore: template prometheus endpoint in examples rather than hardcode #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 116 116
Lines 3393 3393
Branches 685 685
=======================================
Hits 3132 3132
Misses 261 261 |
…dcode Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
force-pushed
the
prom-endpoint-templating
branch
from
285a244
to
7d3d3a0
Compare
|
Sorry for the force push, just cleaned up history, ready for review now. |
mayurkale22
approved these changes
Jun 4, 2020
| @@ -8,7 +8,9 @@ const exporter = new PrometheusExporter( | |||
| startServer: true, | |||
| }, | |||
| () => { | |||
| console.log('prometheus scrape endpoint: http://localhost:9464/metrics'); | |||
| console.log( | |||
| `prometheus scrape endpoint: http://localhost:${PrometheusExporter.DEFAULT_OPTIONS.port}${PrometheusExporter.DEFAULT_OPTIONS.endpoint}`, | |||
dyladan
approved these changes
Jun 4, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes